add the unparam linter to golangci and fix those issues flagged #643
Conversation
k8s-ci-robot
added
the
kind/cleanup
k8s-ci-robot
added
cncf-cla: yes
✅ Deploy Preview for kubernetes-sigs-jobset canceled.
|
kannon92
force-pushed
the
unusued-param-lint
branch
from
885f91c
to
f1fc56f
Compare
k8s-ci-robot
added
size/M
pkg/webhooks/jobset_webhook.go
Outdated
| @@ -382,7 +382,7 @@ func validateCoordinator(js *jobset.JobSet) error { | |||
|
|
|||
| // replicatedJobByName fetches the replicatedJob spec from the JobSet by name. | |||
| // Returns nil if no replicatedJob with the given name exists. | |||
| func replicatedJobByName(js *jobset.JobSet, replicatedJob string) *jobset.ReplicatedJob { | |||
| func replicatedJobByName(js *jobset.JobSet) *jobset.ReplicatedJob { | |||
There was a problem hiding this comment.
Looks like in #627 the replicatedJobByName function had a bug that was missed. We should keep the replicatedJob string param for this function, but on line 387 it should say:
if rjob.Name == replicatedJob {
...
}rather than hardcoding the rjob.Name == js.spec.coordinator.replicatedJob. The coordinator replicatedJob is being passed in as a param by the caller.
There was a problem hiding this comment.
kk. Feel free to propose a PR to fix that bug. I'll add this in after.
There was a problem hiding this comment.
sounds good, just created #645 with the fix
There was a problem hiding this comment.
updated with your fix.
danielvegamyhre
added
the
tide/merge-method-squash
kannon92
force-pushed
the
unusued-param-lint
branch
from
f1fc56f
to
c1e2ace
Compare
k8s-ci-robot
added
size/S
|
/lgtm Thanks for adding this! |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danielvegamyhre, kannon92 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
add linter for unused parameters.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?